RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]
Artur Barashev
abarashev at openjdk.org
Wed Jun 25 19:51:41 UTC 2025
On Wed, 25 Jun 2025 07:42:29 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java line 247:
>>
>>> 245: if (quicEngine != null) {
>>> 246: if (quicEngine instanceof QuicTLSEngineImpl engineImpl) {
>>> 247: return engineImpl.getAlgorithmConstraints();
>>
>> Any particular reason constraints selection code was moved to `engineImpl.getAlgorithmConstraints()` and not kept in this file for consistency with `SSLEngine` and `SSLSocket`?
>
> Hello Artur, we currently don't expose the `HandshakeContext` outside of the `QuicTLSEngineImpl`. The `HandshakeContext` is what is needed to get the relevant user specified algorithm constraints. So I decided to let the `HandshakeContext` be an internal detail in `QuicTLSEngineImpl` and introduce the `getAlgorithmConstraints()` method on it. Do you think we should hand out the `HandshakeContext` outside of `QuicTLSEngineImpl`?
Hi Jaikiran! Sounds good. It's likely we are going to re-work this code anyhow when we make QUIC engine public in the next iteration. We had a discussion with Daniel about it today.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2167491992
More information about the net-dev
mailing list