RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

Daniel Fuchs dfuchs at openjdk.org
Fri Jun 27 08:19:06 UTC 2025


On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Hi,
>> 
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP Client API](https://openjdk.org/jeps/517).
>> 
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8350588)
>> 
>> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
>> It adds a non-exposed / non-exported internal implementation of the QUIC protocol based on DatagramChannel and the SunJSSE SSLContext provider.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 525 commits:
> 
>  - merge latest changes from master branch
>  - http3: run H3StreamLimitReachedTest.java with -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too
>  - retry the ResetControlStream test as needed
>  - http3: fix pending connection and reconnection on stream limit reached logic
>  - http3: pending acknowledgement should be registered before actually sending the packet
>  - http3: fix race with ping requests in PacketSpaceManager.java causing intermittent failures in H3ErrorHandlingTest.java
>  - http3: improve exceptions in Http3ServerExchange.java
>  - http3: fix exception handling in CancelRequestTest.java
>  - http3: review feedback - revert HPACK.java
>  - Implement X509TrustManagerImpl#checkClientTrusted for QUIC
>  - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215

src/java.base/share/classes/sun/security/ssl/QuicCipher.java line 375:

> 373:             super(cipherSuite, secret, new T13AESHPCipher(hp), keyPhase);
> 374:             this.key = key;
> 375:             this.iv = iv;

Suggestion:

            this.iv = iv.clone();

src/java.base/share/classes/sun/security/ssl/QuicCipher.java line 451:

> 449:             super(cipherSuite, secret, new T13AESHPCipher(hp), keyPhase);
> 450:             this.key = key;
> 451:             this.iv = iv;

Suggestion:

            this.iv = iv.clone();

src/java.base/share/classes/sun/security/ssl/QuicCipher.java line 619:

> 617:             super(cipherSuite, secret, new T13CC20HPCipher(hp), keyPhase);
> 618:             this.key = key;
> 619:             this.iv = iv;

Suggestion:

            this.iv = iv.clone();

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2171138262
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2171167148
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2171168244


More information about the net-dev mailing list