RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]
Daniel Fuchs
dfuchs at openjdk.org
Fri Jun 27 11:39:55 UTC 2025
On Fri, 27 Jun 2025 11:22:51 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java with -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too
>> - retry the ResetControlStream test as needed
>> - http3: fix pending connection and reconnection on stream limit reached logic
>> - http3: pending acknowledgement should be registered before actually sending the packet
>> - http3: fix race with ping requests in PacketSpaceManager.java causing intermittent failures in H3ErrorHandlingTest.java
>> - http3: improve exceptions in Http3ServerExchange.java
>> - http3: fix exception handling in CancelRequestTest.java
>> - http3: review feedback - revert HPACK.java
>> - Implement X509TrustManagerImpl#checkClientTrusted for QUIC
>> - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215
>
> src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 216:
>
>> 214:
>> 215: // true if previous attempt resulted in streamLimitReached
>> 216: public boolean hasReachedStreamLimit(Version version) { return streamLimitReached == version; }
>
> it seems that `streamLimitReached` will either be equal to `version` or `null`. If that's the case, let's use a boolean instead.
That's a good point.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2171718034
More information about the net-dev
mailing list