RFR: 8361060: Keep track of the origin server against which a jdk.internal.net.http.HttpConnection was constructed
Daniel Fuchs
dfuchs at openjdk.org
Mon Jun 30 11:28:40 UTC 2025
On Mon, 30 Jun 2025 11:07:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which updates the `jdk.internal.net.http.HttpConnection` to keep track of the origin server for which the `HttpConnection` was constructed? This addresses https://bugs.openjdk.org/browse/JDK-8361060.
>
> This is an internal implementation change which will allow other parts of the JDK's HttpClient implementation to use the origin server information. An example of such usage is the alternate services that are going to be supported in the JDK's HttpClient upcoming implementation for HTTP/3.
>
> No new tests have been introduced and existing tests in tier1, tier2 and tier3 continue to pass.
src/java.net.http/share/classes/jdk/internal/net/http/AsyncSSLConnection.java line 50:
> 48: String[] alpn,
> 49: String label) {
> 50: super(originServer, addr, client, Utils.getServerName(addr), addr.getPort(), alpn, label);
Do we still need Utils.getServerName(addr), addr.getPort(), now that we have originServer? Or in other words - should we base these calls on the `addr` parameter or on the `originServer` parameters?
src/java.net.http/share/classes/jdk/internal/net/http/AsyncSSLTunnelConnection.java line 54:
> 52: String label)
> 53: {
> 54: super(originServer, addr, client, Utils.getServerName(addr), addr.getPort(), alpn, label);
Same question
src/java.net.http/share/classes/jdk/internal/net/http/Origin.java line 94:
> 92: return host + ":" + port;
> 93: }
> 94: }
Missing newline.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26041#discussion_r2174834618
PR Review Comment: https://git.openjdk.org/jdk/pull/26041#discussion_r2174835728
PR Review Comment: https://git.openjdk.org/jdk/pull/26041#discussion_r2174839334
More information about the net-dev
mailing list