RFR: 8361060: Keep track of the origin server against which a jdk.internal.net.http.HttpConnection was constructed

Daniel Fuchs dfuchs at openjdk.org
Mon Jun 30 11:31:37 UTC 2025


On Mon, 30 Jun 2025 11:07:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which updates the `jdk.internal.net.http.HttpConnection` to keep track of the origin server for which the `HttpConnection` was constructed? This addresses https://bugs.openjdk.org/browse/JDK-8361060.
> 
> This is an internal implementation change which will allow other parts of the JDK's HttpClient implementation to use the origin server information. An example of such usage is the alternate services that are going to be supported in the JDK's HttpClient upcoming implementation for HTTP/3.
> 
> No new tests have been introduced and existing tests in tier1, tier2 and tier3 continue to pass.

src/java.net.http/share/classes/jdk/internal/net/http/Origin.java line 48:

> 46:             throw new IllegalArgumentException("Invalid port");
> 47:         }
> 48:     }

Should we enforce lower case for scheme and host in this constructor?
For instance - convert to lower case if needed in `from(URI)` and throw/assert here if not lower case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26041#discussion_r2174852642


More information about the net-dev mailing list