RFR: 8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException [v2]

duke duke at openjdk.org
Wed Mar 5 16:40:00 UTC 2025


On Mon, 10 Feb 2025 11:47:25 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> java.net.URI.scanIPv4Address is a private method, it is only called by java.net.URI.takeIPv4Address and java.net.URI.parseIPv4Address, the URISyntaxException("Malformed IPv4 address") is not necessary, returning -1 should be good. In one of our systems, we noticed the exception consumes ~0.3% CPU.
>> 
>> Additional test:
>> - [x] make test TEST=jdk/java/net
>> - [x] all tier2 tests(except DirectIOTest.java which is a [known issue](https://bugs.openjdk.org/browse/JDK-8333783))
>
> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address PR comments

@pengxiaolong 
Your change (at version be5bedd2e6278a8b391a06961ace55dfa072b6df) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23538#issuecomment-2701479299


More information about the net-dev mailing list