RFR: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN [v2]
Volkan Yazici
vyazici at openjdk.org
Thu Mar 13 15:49:58 UTC 2025
On Thu, 13 Mar 2025 13:42:40 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Fixes endian handling `jdk.internal.net.http.websocket.Frame.Masker`.
>>
>> ### Implementation notes
>>
>> I deleted the `Frame` clone in tests, and rewired the test code depending on it to the actual `Frame`. To enable this, I relaxed the visibility of the actual `Frame`. I guess the `Frame` clone was introduced to have strict visibility in the actual `Frame`. Though this is not needed since the actual `Frame` is in an internal package. Plus, the fact that bug is in the `Frame` class hints in the direction that there should be one `Frame`.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix copyright years
Successful `tier1,2` runs on 6baa69eee35e624227a3be8bc53abf52ea07edaa are attached to the ticket.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24033#issuecomment-2721726006
More information about the net-dev
mailing list