RFR: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN [v5]
Michael McMahon
michaelm at openjdk.org
Fri Mar 21 15:10:08 UTC 2025
On Fri, 21 Mar 2025 11:41:45 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Fixes endian handling `jdk.internal.net.http.websocket.Frame.Masker`.
>>
>> ### Implementation notes
>>
>> I deleted the `Frame` clone in tests, and rewired the test code depending on it to the actual `Frame`. To enable this, I relaxed the visibility of the actual `Frame`. I guess the `Frame` clone was introduced to have strict visibility in the actual `Frame`. Though this is not needed since the actual `Frame` is in an internal package. Plus, the fact that bug is in the `Frame` class hints in the direction that there should be one `Frame`.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>
> Improve `applyVectorMask` JavaDoc
>
> Co-authored-by: Michael McMahon <70538289+Michael-Mc-Mahon at users.noreply.github.com>
I'm okay with this change, with or without the 2nd comment suggestion
-------------
Marked as reviewed by michaelm (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24033#pullrequestreview-2706300418
More information about the net-dev
mailing list