RFR: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN [v5]

Volkan Yazici vyazici at openjdk.org
Mon Mar 24 09:52:11 UTC 2025


On Sun, 23 Mar 2025 08:47:51 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve `applyVectorMask` JavaDoc
>>   
>>   Co-authored-by: Michael McMahon <70538289+Michael-Mc-Mahon at users.noreply.github.com>
>
> test/jdk/java/net/httpclient/websocket/Abort.java line 26:
> 
>> 24: /*
>> 25:  * @test
>> 26:  * @modules java.net.http/jdk.internal.net.http.websocket
> 
> Instead of adding this line to all tests, you can add a new `TEST.properties` that contains:
> 
> modules = java.net.http/jdk.internal.net.http.websocket
> 
> And only add `@modules` for files that require extra modules. See other `TEST.properties` in the JDK.

Good call – this indeed reduces the size of touched files. Implemented in f5d347157bb8dd8e56457be489fc8899df286f5c.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24033#discussion_r2009811292


More information about the net-dev mailing list