RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v4]

[Daniel Fuchs]

On Thu, 27 Mar 2025 13:02:24 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve JavaDoc
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java line 100:
> 
>> 98:      * {@link PlainHttpConnection} it wraps will share the same label. As a
>> 99:      * result, compared to {@link #id}, this label does not give a total order
>> 100:      * among instances.
> 
> Hello Volkan, I think we shouldn't talk about any kind of ordering here. I see that the `id` field has been updated with a comment stating that it provides ordering among instances. Even there, I don't think that comment about ordering is needed. So far we haven't used the `id` to mean anything other than a logical identifier and these values have played no role in ordering of connections at any place. So adding the comments about ordering, I think, makes it confusing.

The only use of `HttpConnection.id` is for ordering - so that connections can be placed in a ConcurrentSkipListSet. So maybe here we should not speak of ordering (remove the last sentence in that paragraph) - but I think it helps to keep it for `id`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2016726419