RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v4]

[Daniel Fuchs]

On Thu, 27 Mar 2025 13:07:44 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve JavaDoc
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java line 81:
> 
>> 79:             = Comparator.comparing(HttpConnection::id);
>> 80: 
>> 81:     private static final AtomicLong LABEL_COUNTER = new AtomicLong();
> 
> In the API documentation on `HttpResponse.connectionLabel()` we talk about the connection label being unique within a `HttpClient` scope. i.e. two different `HttpClient` instances could have the same connectionLabel for a connection. I think that's the right scoping.
> 
> So given that, having a `static` field on a `HttpConnection` which keeps track of a connection label, may not be the right place to keep track of that state. In this proposed form, no two connections in two different HttpClient instances will ever have the same connectionLabel. I think this counter should probably be present on the `HttpClientImpl` as an instance field.

I believe that's OK. We could go either way - but I'd rather keep the label unique regardless of the client because otherwise we would also need to include the client id in the debug traces (ATM we only have the label). If it's unique in the scope of the VM it's a fortiori unique in the scope of the client instance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2016739145