RFR: 8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value

Daniel Fuchs dfuchs at openjdk.org
Fri May 2 08:50:45 UTC 2025


On Fri, 2 May 2025 08:26:48 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

> Replaces `os.name` checks in tests with `@requires`. This prevents these tests from being run, and superficial results being generated, on unnecessary platforms.
> 
> Note that `os.name` checks are replaced with `os.family` instead.

test/jdk/java/net/MulticastSocket/PromiscuousIPv6.java line 27:

> 25:  * @test
> 26:  * @bug 8215294
> 27:  * @requires os.family == "linux" & !(os.version ~= "3\\.10\\.0.*")

Suggestion:

 * @requires os.family == "linux" & !(os.version ~= "3\.10\.0.*")
 * @comment This test should only be run on Linux.
 *          The behavior under test is known NOT to work on Linux 3.10.0* kernels.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24997#discussion_r2071295887


More information about the net-dev mailing list