RFR: 8355578: [java.net] Use @requires tag instead of exiting based on "os.name" property value [v2]
Daniel Fuchs
dfuchs at openjdk.org
Wed May 7 11:33:16 UTC 2025
On Fri, 2 May 2025 09:15:24 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Replaces `os.name` checks in tests with `@requires`. This prevents these tests from being run, and superficial results being generated, on unnecessary platforms.
>>
>> Note that `os.name` checks are replaced with `os.family` instead.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>
> Document `@requires` rationale with `@comment`
>
> Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>
test/jdk/java/net/MulticastSocket/PromiscuousIPv6.java line 27:
> 25: * @test
> 26: * @bug 8215294
> 27: * @requires os.family == "linux" & !(os.version ~= "3\\.10\\.0.*")
Would that match 13.10.01?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24997#discussion_r2077418883
More information about the net-dev
mailing list