RFR: 8355360: -d option of jwebserver command should accept relative paths [v4]
Daniel Fuchs
dfuchs at openjdk.org
Fri May 9 15:30:53 UTC 2025
On Fri, 9 May 2025 09:53:08 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Allows relative paths in the content root directory passed to the `jwebserver`. Changes effect both the `jwebserver` executable and the `java -m jdk.httpserver` execution.
>>
>> ### Implementation notes
>>
>> Received `Path` is read using `toRealPath()`, and then employed in `s.n.h.s.FileServerHandler`, which is the only place in the web server code where an absolute path requirement is present.
>
> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>
> - Fix license year
> - Move path resolution back to option parsing
LGTM
Sorry - I have approved too fast - aren't there some man pages to update too?
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25113#pullrequestreview-2828796875
PR Comment: https://git.openjdk.org/jdk/pull/25113#issuecomment-2867002134
More information about the net-dev
mailing list