RFR: 8341346: Add support for exporting TLS Keying Material [v20]
Jamil Nimeh
jnimeh at openjdk.org
Mon May 19 22:41:57 UTC 2025
On Mon, 19 May 2025 20:28:46 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE respectively.
>>
>> CSR is underway.
>>
>> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
>
> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
>
> get*() no longer needed, backout error (oops!)
src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1672:
> 1670: // RFC 5705, "If no context is provided, ..."
> 1671: seed[pos++] = (byte) ((context.length >> 8) & 0xFF);
> 1672: seed[pos++] = (byte) ((context.length) & 0xFF);
Because you're doing a primitive narrowing conversion down to a byte I don't think you need the 0xFF masking.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24976#discussion_r2096561543
More information about the net-dev
mailing list