RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v5]
Valerie Peng
valeriep at openjdk.org
Wed May 21 01:08:55 UTC 2025
On Tue, 20 May 2025 16:10:07 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to use `JavaNioAccess::getBufferAdress` rather than `DirectBuffer::address` so that `Buffer` instances backed by MemorySegment instances can be used in classes that were not covered by https://github.com/openjdk/jdk/pull/25321
>>
>> This PR passes tier1, tier2, and tier3 tests on multiple platforms and configurations.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Update after comments
src/java.base/unix/classes/sun/nio/fs/UnixUserDefinedFileAttributeView.java line 176:
> 174: dst.position(pos + n);
> 175: return n;
> 176: } finally {
nit: extra space before finally?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25324#discussion_r2099108417
More information about the net-dev
mailing list