RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v3]
Per Minborg
pminborg at openjdk.org
Wed May 21 13:31:53 UTC 2025
On Wed, 21 May 2025 09:10:57 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> > > A question for folks on security-dev. Are there tests for Cipher.doFinal, CipherSpi.engineUpdate, etc. that exercises cases where the ByteBuffer obtained from a memory segment?
> >
> >
> > I don't find any. We'd have to update them to cover the memory segment usage. Judging from the changed sources, general Cipher and SunPKCS11-specific tests update would be needed.
>
> Thanks for checking. We need to create an issue in JBS for this. It may be a corner case to use these APIs and SPI with buffers that are views on a memory segment but it will happen at some point and would be good to ensure that it is covered by tests.
I've created https://bugs.openjdk.org/browse/JDK-8357466. There are some missing fields, I hope someone can fill them in.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25324#issuecomment-2897977877
More information about the net-dev
mailing list