RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

Mark Sheppard msheppar at openjdk.org
Fri May 23 13:35:54 UTC 2025


On Fri, 23 May 2025 09:57:02 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> > If I have read the original code correctly there is a flaw in it, that is the startExchange is never called.
> 
> @msheppar what do you mean by that? It's called in [ExchangeImpl.java](https://github.com/openjdk/jdk/blob/68ee06f0c9ec420cb1a60e0b361971372b18b82b/src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java#L98)

Well then I haven't read it correctly :-(  needs a deeper dive, I didn't examine the Exchange::run method in sufficient detail   ... thanks for the correction ....  BUT in my defence I see Dispatcher invoke handle, handle creates an Exchange, which is dispatched to an Executor and I would have expected that the run method of Exchange to call startExchange, as the log message says an exchange has started !!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25333#issuecomment-2904441249


More information about the net-dev mailing list