RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]
Alan Bateman
alanb at openjdk.org
Mon May 26 07:35:18 UTC 2025
On Wed, 21 May 2025 13:42:39 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to use `JavaNioAccess::getBufferAdress` rather than `DirectBuffer::address` so that `Buffer` instances backed by MemorySegment instances can be used in classes that were not covered by https://github.com/openjdk/jdk/pull/25321
>>
>> This PR passes tier1, tier2, and tier3 tests on multiple platforms and configurations.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix copyright year
src/java.base/unix/classes/sun/nio/fs/UnixUserDefinedFileAttributeView.java line 169:
> 167: int rem = (pos <= lim ? lim - pos : 0);
> 168:
> 169: if (dst instanceof sun.nio.ch.DirectBuffer) {
I assume this can be changed to test dst.isDirect() now and avoid the explicit cross package dependency.
src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java line 41:
> 39: import jdk.internal.invoke.MhUtil;
> 40:
> 41: import static sun.nio.ch.Util.NIO_ACCESS;
I assume this is left over from a previous iteration.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25324#discussion_r2106733233
PR Review Comment: https://git.openjdk.org/jdk/pull/25324#discussion_r2106735489
More information about the net-dev
mailing list