RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]
Michael McMahon
michaelm at openjdk.org
Mon May 26 16:11:53 UTC 2025
On Thu, 22 May 2025 12:27:46 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> HttpServer::stop will terminate the server immidiately after all exhcnages are complete.
>> If the exchanges take longer then the specified delay it will terminate straight after the delay, the same as the previous behaviour.
>>
>> Used to wait until the delay is complete at all times, regardless of the number of active exchanges.
>>
>> Tests based on @eirbjo work, so adding Eirik as a contributor.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>
> Suggestions from cr
>
> Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>
I wonder could the two Event types be consolidated inside Event.java? It seems overkill to have them in three separate source files now.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25333#pullrequestreview-2868836454
More information about the net-dev
mailing list