RFR: 8348986: Improve coverage of enhanced exception messages [v11]
Alan Bateman
alanb at openjdk.org
Mon May 26 19:25:00 UTC 2025
On Mon, 26 May 2025 19:06:56 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:
>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 28 commits:
>>
>> - Merge branch 'master' into 8348986-exceptions
>> - update
>> - reduced number of new categories
>> - Merge branch 'master' into 8348986-exceptions
>> - Merge branch 'master' into 8348986-exceptions
>> - Merge branch 'master' into 8348986-exceptions
>> - Merge branch 'master' into 8348986-exceptions
>> - Review update
>> - review update
>> - Merge branch 'master' into 8348986-exceptions
>> - ... and 18 more: https://git.openjdk.org/jdk/compare/e961b13c...cc518c19
>
> src/java.base/share/classes/jdk/internal/util/Exceptions.java line 253:
>
>> 251: return;
>> 252: enhancedSocketExceptionText = SecurityProperties.includedInExceptions("hostInfo");
>> 253: enhancedNonSocketExceptionText = SecurityProperties.includedInExceptions("hostInfoExclSocket")
>
> This looks like the inverse of the previous use of a socket category, except this time it anything that is not in Socket.
>
> Consider the following:
> includeInException specifies the type of information that maybe included in an enhanced exception
> e.g. Hostname, IPAddress, PortNumber, UserDetails, Uri (including Urls), JarDetails, All
> This defines an information policy
>
> developer are familiar with packages, so a second property specified the "domain" of application of an information policy: enhancedException.packages specifies a list of packages where the includeInException information policy will apply
>
> an empty list or the enhancedException.packages means freedom of information and the defined includedInException applies to all packages
> This looks like the inverse of the previous use of a socket category, except this time it anything that not in Socket.
I think the PR has it right. No change to existing behavior. To opt-in and reveal more host information in exceptions then you can run it with configured to "hostInfo". It does mean repurposing the name but it's a good name going forward.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23929#discussion_r2107784068
More information about the net-dev
mailing list