RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v5]

[Mark Sheppard]

On Tue, 27 May 2025 13:25:38 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> HttpServer::stop will terminate the server immidiately after all exhcnages are complete.
>> If the exchanges take longer then the specified delay it will terminate straight after the delay, the same as the previous behaviour.
>> 
>> Used to wait until the delay is complete at all times, regardless of the number of active exchanges.
>> 
>> Tests based on @eirbjo work, so adding Eirik as a contributor.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   consolidated events

src/jdk.httpserver/share/classes/sun/net/httpserver/Event.java line 35:

> 33:         this.exchange = t;
> 34:     }
> 35: 

I don't see the purpose of this change and the value it brings other than collation and reducing explicit files for the derived Events ?
Could you elaborate the rationale please?

I do see a code smell in WriteFinished directly access the state of ExchangeImpl

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25333#discussion_r2109214767