RFR: 8341346: Add support for exporting TLS Keying Material [v27]
Bradford Wetmore
wetmore at openjdk.org
Thu May 29 20:37:54 UTC 2025
On Thu, 29 May 2025 14:12:47 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> - Remove TlsExporterKeyingMaterial for now. Can add later if needed.
>> - Merge branch 'master' into JDK-8341346
>> - Merge branch 'master' into JDK-8341346
>> - Added PKCS11 testing
>> - Minor bug
>> - Missed one change
>> - Merge branch 'master' into JDK-8341346
>> - Private Codereview comment: Don't allow use of null keyAlgs, plus some minor cleanups
>> - get*() no longer needed, backout error (oops!)
>> - ... and 27 more: https://git.openjdk.org/jdk/compare/2ec6ab34...858362c8
>
> src/java.base/share/classes/sun/security/internal/spec/TlsPrfParameterSpec.java line 85:
>
>> 83: * @param secret the secret to use in the calculation (or null)
>> 84: * @param keyAlg the algorithm name that the generated SecretKey should
>> 85: * have, or null if the default should be used
>
> You no longer allow it to be `null`.
Egads, good catch. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24976#discussion_r2114708506
More information about the net-dev
mailing list