RFR: 8228773: URLClassLoader constructors should include API note warning that the parent should not be null [v3]

[Jaikiran Pai]

On Thu, 29 May 2025 16:50:49 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   additional sentence to the apiNote
>
> src/java.base/share/classes/java/net/URLClassLoader.java line 87:
> 
>> 85:      *
>> 86:      * @param      urls the URLs from which to load classes and resources
>> 87:      * @param      parent the parent class loader for delegation, can be null
> 
> s/null/{@code null}/

Fixed in the latest update of this PR.

> src/java.base/share/classes/java/net/URLClassLoader.java line 123:
> 
>> 121:      * obtain protocol handlers when creating new jar URLs.
>> 122:      *
>> 123:      * @apiNote If the {@code parent} is specified as {@code null} (for the
> 
> I think "If {@code parent}" is more correct, since you are implicitly referring to the parameter.

Done.

> src/java.base/share/classes/java/net/URLClassLoader.java line 127:
> 
>> 125:      * classes are visible.
>> 126:      * See {@linkplain ClassLoader##builtinLoaders Run-time Built-in Class Loaders}
>> 127:      * for information on the system class loader and other built-in class loaders.
> 
> Seems more relevant to say "for information on the bootstrap class loader and other built-in class loaders." since you specifically mention bootstrap loader in the first sentence.

Fixed in the latest update of this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25517#discussion_r2115255429
PR Review Comment: https://git.openjdk.org/jdk/pull/25517#discussion_r2115255846
PR Review Comment: https://git.openjdk.org/jdk/pull/25517#discussion_r2115255640