RFR: 8208693: HttpClient: Extend the request timeout's scope to cover the response body [v7]
Volkan Yazici
vyazici at openjdk.org
Mon Nov 3 14:42:25 UTC 2025
On Mon, 3 Nov 2025 12:40:45 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Simplify Javadoc
>
> src/java.net.http/share/classes/java/net/http/HttpClient.java line 321:
>
>> 319: * @throws IllegalArgumentException if the duration is non-positive
>> 320: * @see HttpRequest.Builder#timeout(Duration) Configuring timeout for
>> 321: * request execution
>
> Did you verify what javadoc generated for that?
<img width="894" height="524" alt="image" src="https://github.com/user-attachments/assets/c2b3666c-f0cd-4060-9088-0d812bf6cdab" />
> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 282:
>
>> 280: * @throws IllegalArgumentException if the duration is non-positive
>> 281: * @see HttpClient.Builder#connectTimeout(Duration) Configuring
>> 282: * timeout for connection establishment
>
> Same here - please verify how this looks in generated API doc
<img width="894" height="602" alt="image" src="https://github.com/user-attachments/assets/19d6f6b2-5704-431e-818d-14e739717855" />
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27469#discussion_r2486707602
PR Review Comment: https://git.openjdk.org/jdk/pull/27469#discussion_r2486712247
More information about the net-dev
mailing list