RFR: 8208693: HttpClient: Extend the request timeout's scope to cover the response body [v9]
Volkan Yazici
vyazici at openjdk.org
Wed Nov 5 10:40:41 UTC 2025
On Wed, 5 Nov 2025 10:29:22 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Currently `HttpRequest::timeout` only applies until the response headers are received. Extend its scope to also cover the consumption of the response body.
>>
>> ### Review guidelines
>>
>> 1. Read _"the fix"_ in `MultiExchange`
>> 2. Skim through the test server *handler* in `TimeoutResponseTestSupport`
>> 3. Review first `TimeoutResponseHeaderTest`, and then `TimeoutResponseBodyTest` (Mind the multiple `@test` blocks!)
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>
> Cancel timer on 204
src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java line 391:
> 389: // Ensure that the connection is closed or returned to the pool
> 390: exch.nullBody(response, throwable);
> 391: });
@dfuch, I've introduced this improvement against 204s, which you internally tipped me, in 480349b672e. Though I could not come up with a way to decently test this. Any suggestions?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27469#discussion_r2493900320
More information about the net-dev
mailing list