RFR: 8368528: HttpClient.Builder.connectTimeout should accept arbitrarily large values [v8]
Daniel Fuchs
dfuchs at openjdk.org
Wed Nov 5 11:39:05 UTC 2025
On Tue, 4 Nov 2025 20:09:44 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Introduce necessary fixes to address exceptions thrown when excessive `Duration`s are provided to `Duration`-accepting `HttpClient` public APIs.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>
> Test `h3` infra with `j.h.k.timeout.h2`
Marked as reviewed by dfuchs (Reviewer).
test/jdk/java/net/httpclient/whitebox/DeadlineOverflowTestDriver.java line 30:
> 28: * @modules java.net.http/jdk.internal.net.http.common:+open
> 29: * @run junit java.net.http/jdk.internal.net.http.common.DeadlineOverflowTest
> 30: */
Putting the test in the `jdk.internal.net.http.common` package and having a driver to run it was probably unecessary in this case. I think a simple test under `test/jdk/java/net/httpclient` would have worked too since you're only accessing public (even though not exported) APIs.
That said having this test under `.../whitebox/` makes kind of sense too so I'm good with that.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27973#pullrequestreview-3421427378
PR Review Comment: https://git.openjdk.org/jdk/pull/27973#discussion_r2494089212
More information about the net-dev
mailing list