RFR: 8368528: HttpClient.Builder.connectTimeout should accept arbitrarily large values [v8]

Daniel Fuchs dfuchs at openjdk.org
Wed Nov 5 14:21:23 UTC 2025


On Wed, 5 Nov 2025 13:13:44 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> test/jdk/java/net/httpclient/whitebox/DeadlineOverflowTestDriver.java line 30:
>> 
>>> 28:  * @modules java.net.http/jdk.internal.net.http.common:+open
>>> 29:  * @run junit java.net.http/jdk.internal.net.http.common.DeadlineOverflowTest
>>> 30:  */
>> 
>> Putting the test in the `jdk.internal.net.http.common` package and having a driver to run it was probably unecessary in this case. I think a simple test under `test/jdk/java/net/httpclient` would have worked too since you're only accessing public (even though not exported) APIs.
>> That said having this test under `.../whitebox/` makes kind of sense too so I'm good with that.
>
> Since `Deadline::of` is package-private, I've placed the test to `whitebox` with a `package jdk.internal.net.http.common` preamble.

Oh - OK. Makes sense then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27973#discussion_r2494715793


More information about the net-dev mailing list