RFR: 8208693: HttpClient: Extend the request timeout's scope to cover the response body [v10]

Volkan Yazici vyazici at openjdk.org
Thu Nov 6 13:19:29 UTC 2025


On Thu, 6 Nov 2025 12:25:48 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Clarify WebSocket behaviour and test it
>>  - Verify no lingering response timers
>
> test/jdk/java/net/httpclient/websocket/WebSocketTest.java line 172:
> 
>> 170:                         .newWebSocketBuilder()
>> 171:                         .buildAsync(server.getURI(), webSocketListener)
>> 172:                         .join();
> 
> Shouldn't you add a `connectTimeout` to the web socket builder? Otherwise of course you won't find any :-)

I was naively expecting `WebSocket.Builder` to inherit `connectTimeout` from the parent `HttpClient`, I was indeed mistaken. Corrected it in c3210d88d0c.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27469#discussion_r2498931056


More information about the net-dev mailing list