RFR: 8371471: HttpClient: Log HTTP/3 handshake failures if logging errors is enabled [v2]

Jaikiran Pai jpai at openjdk.org
Fri Nov 7 15:13:20 UTC 2025


On Fri, 7 Nov 2025 14:51:32 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Surprisingly if the QUIC handshake fails exceptionally, and `-Djdk.httpclient.HttpClient.log=errors` is specified, the exception is not logged. This change fixes that.
>
> Daniel Fuchs has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - More copyright dates
>  - small test cleanup
>  - Fix copyright dates

test/jdk/java/net/httpclient/http3/H3LogHandshakeErrors.java line 119:

> 117: 
> 118:         // create a client that doesn't have the server's
> 119:         // certificate

Should we reword this to:


// create a client without the test specific SSLContext 
// so that the client doesn't have the server's
// certificate

test/jdk/java/net/httpclient/http3/H3LogHandshakeErrors.java line 126:

> 124:         final HttpRequest.Builder reqBuilder = HttpRequest.newBuilder(reqURI)
> 125:                 .version(HTTP_3);
> 126:         Logger serverLogger = Logger.getLogger("jdk.httpclient.HttpClient");

Should we add a reachability fence for this `serverLogger`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2504058024
PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2504065336


More information about the net-dev mailing list