RFR: 8371471: HttpClient: Log HTTP/3 handshake failures if logging errors is enabled [v2]
Jaikiran Pai
jpai at openjdk.org
Fri Nov 7 15:18:20 UTC 2025
On Fri, 7 Nov 2025 14:51:32 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Surprisingly if the QUIC handshake fails exceptionally, and `-Djdk.httpclient.HttpClient.log=errors` is specified, the exception is not logged. This change fixes that.
>
> Daniel Fuchs has updated the pull request incrementally with three additional commits since the last revision:
>
> - More copyright dates
> - small test cleanup
> - Fix copyright dates
test/jdk/java/net/httpclient/http3/H3LogHandshakeErrors.java line 153:
> 151: // place where we log the exception from changes.
> 152: String expectedClassName = QuicConnectionImpl.class.getName()
> 153: + "$HandshakeFlow";
Would just asserting for the (expected) log message and the presence of stacktrace be enough? Irrespective of which class logs it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2504078683
More information about the net-dev
mailing list