RFR: 8326498: java.net.http.HttpClient connection leak using http/2 [v2]

Volkan Yazici vyazici at openjdk.org
Wed Nov 12 11:22:30 UTC 2025


On Wed, 12 Nov 2025 08:53:48 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - mark jdk.internal.net.http.Http2Connection as Closable
>>  - reduce number of concurrent requests
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2TerminationCause.java line 84:
> 
>> 82:      * such cases.
>> 83:      */
>> 84:     public abstract boolean isErroneousClose();
> 
> nit: can we use a different word here? "Erroneous close" feels vague here; would "is(Non)Graceful", "isAbrupt" or "hasErrorCode" capture the intent?

That that `erroneous close` has been used in several other contexts; in code, in comments, etc. If this gets updated, I'd appreciate other relevant occurrences get updated too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2517709873


More information about the net-dev mailing list