RFR: 8347167: Implementation in com.sun.net.httpserver.Headers.normalize() can be improved [v2]

[Daniel Fuchs]

On Tue, 18 Nov 2025 14:41:33 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Josiah Noel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   patch
>
> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line 157:
> 
>> 155:                 throw new IllegalArgumentException("illegal character in key at index " + i);
>> 156:             }
>> 157:             cs[0] = (char) (c - o);
> 
> There's an assumption here that because of the test at line 135 then `c` must be a lower case letter. But, it could in principle be any `tchar` (token character) which includes digits and vchars other than lower case letters. We should check `if (c >= 'a' && c <= 'z')`

Ah! Good catch Michael!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27276#discussion_r2538473378