RFR: 8326498: java.net.http.HttpClient connection leak using http/2 [v6]
Jaikiran Pai
jpai at openjdk.org
Wed Nov 19 10:24:50 UTC 2025
On Wed, 12 Nov 2025 09:23:56 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:
>>
>> - rename method
>> - remove unneeded method
>> - logging and javadoc comment fixes
>> - merge latest from master branch
>> - update test to use h2c HTTP/2 server
>> - fix typo in test code comment
>> - trivial debug log check change
>> - rename isErroneousClose() to isAbnormalClose()
>> - stackless instance for idle timed out NoError
>> - Volkan's suggestion - log message improvement
>> - ... and 9 more: https://git.openjdk.org/jdk/compare/832ec6d1...c554a521
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2TerminationCause.java line 35:
>
>> 33:
>> 34: /**
>> 35: * Termination cause for a {@linkplain Http2Connection HTTP/2 connection}
>
> Suggestion:
>
> * Termination cause for an {@linkplain Http2Connection HTTP/2 connection}
Done
> src/java.net.http/share/classes/jdk/internal/net/http/Http2TerminationCause.java line 71:
>
>> 69: * Returns the IOException that is considered the cause of the connection termination.
>> 70: * Even a normal {@linkplain #isErroneousClose() non-erroneous} termination will have
>> 71: * a IOException associated with it, so this method will always return a non-null instance.
>
> Suggestion:
>
> * Returns the {@link IOException} that is considered the cause of the connection termination.
> * Even a normal {@linkplain #isErroneousClose() non-erroneous} termination will have
> * an {@code IOException} associated with it, so this method will always return a non-null instance.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2541388804
PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2541389341
More information about the net-dev
mailing list