RFR: 8326498: java.net.http.HttpClient connection leak using http/2 [v7]

Daniel Fuchs dfuchs at openjdk.org
Wed Nov 19 13:13:08 UTC 2025


On Wed, 19 Nov 2025 10:33:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review for this fix which addresses a connection leak in HttpClient when dealing with HTTP/2 requests?
>> 
>> I have added a comment in https://bugs.openjdk.org/browse/JDK-8326498 which explains what the issue is. The fix here addresses the issue by cleaning up the `Http2Connection` closing logic and centralizing it to a connection terminator. The terminator then ensures that the right resources are closed (including the underlying SocketChannel) when the termination happens.
>> 
>> A new jtreg test has been introduced which reproduces the issue and verifies the fix.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use Utils.toIOException()

src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java line 38:

> 36: import java.net.http.HttpHeaders;
> 37: import java.nio.ByteBuffer;
> 38: import java.nio.channels.NetworkChannel;

Unless I'm mistaken this import is not needed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2541897486


More information about the net-dev mailing list