RFR: 8372159: HttpClient SelectorManager thread could be a VirtualThread [v2]

[Daniel Fuchs]

On Thu, 20 Nov 2025 09:33:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert changes to SelectorManager::shutdown
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java line 131:
> 
>> 129: 
>> 130:     static final UseVTForSelector USE_VT_FOR_SELECTOR =
>> 131:         Utils.useVTForSelector("jdk.internal.httpclient.tcp.selector.useVirtualThreads", "default");
> 
> Hello Daniel, I vaguely remember we discussed whether or not to use a value called "default" for this property. But I don't remember what we decided. Looking at this now, I am wondering whether we should just do something like:
> 
> System.getProperty("jdk.internal.httpclient.tcp.selector.useVirtualThreads", "true")
> 
> to keep it simple?

For tcp we only need true/false - but for quic we have a default behavior which depends on the platform. I decided to keep "always/never/default" for both properties for consistency. Let me think about it. I am not sure if that change (true/false for quic too) should be made in this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28395#discussion_r2545212056