RFR: 8326498: java.net.http.HttpClient connection leak using http/2 [v11]

Jaikiran Pai jpai at openjdk.org
Mon Nov 24 10:25:16 UTC 2025


On Mon, 24 Nov 2025 09:25:22 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use ClosedChannelException instead of IOException
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2TerminationCause.java line 268:
> 
>> 266:     private static final class InternalError extends Http2TerminationCause {
>> 267:         private InternalError(final Throwable cause) {
>> 268:             super(ErrorFrame.INTERNAL_ERROR, new Exception(cause));
> 
> why do we need to wrap the throwable here?

I don't remember why I did that this way, but it looks like a leftover from my experiments. I've updated the PR to remove this wrapping. Thank you for catching this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2555626256


More information about the net-dev mailing list