RFR: 8369313: java/net/httpclient/TimeoutBasic.java should accept that HttpTimeoutException should be somewhere down the cause chain

Francesco Andreuzzi fandreuzzi at openjdk.org
Wed Oct 8 16:10:59 UTC 2025


On Wed, 8 Oct 2025 16:02:18 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> test/jdk/java/net/httpclient/TimeoutBasic.java line 153:
>> 
>>> 151:             }
>>> 152:         }
>>> 153:         assert x == null;
>> 
>> Is there a way to exit the loop without `x` being `null`?
>
> @fandreuz why would you want to do that? x == null means the expected cause has not been found. In which case we want to throw the AssertionError, with the root exception as the cause, possibly stripping the outer CompletionException if any as that is of little interest.

What I mean is that the assertion may not be needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27694#discussion_r2414372531


More information about the net-dev mailing list