RFR: 8368625: com/sun/net/httpserver/ServerStopTerminationTest.java fails intermittently in tier7 [v2]
Daniel Fuchs
dfuchs at openjdk.org
Mon Oct 20 18:03:02 UTC 2025
On Mon, 20 Oct 2025 17:37:07 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:
>> Was that a comment for the other test @msheppar - there's no 20s here.
>> I still think a better impl would be to call completeExchange() after timeShutdown() here since we want to verify that the server will stop after the 1s delay even if an exchange is in progress.
>
> it's shouldCompeteAfterDelay the test that fails
>
> final Duration delayDuration = Duration.ofSeconds(Utils.adjustTimeout(20));
> log("Shutdown triggered with the delay of " + delayDuration.getSeconds());
> final long elapsed = timeShutdown(delayDuration, startTime);
> log("Shutdown complete");
>
> the shutdown delay has been increased to 20 seconds
>
> you are verifying that the server will stop after a max time of 20 seconds + (whatever time its takes to terminate whatever needs. to be terminated)
>
> The 1 seconds delay is to activate the Exchange and set it running
The test that fails and has been updated with:
final Duration delayDuration = Duration.ofSeconds(Utils.adjustTimeout(20));
is `shouldAwaitActiveExchange()` so I guess your comment was intended for `shouldAwaitAfterExchange()`.
BTW @myankelev: in `shouldCompeteAfterDelay` is `compete` a typo?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27670#discussion_r2445733524
More information about the net-dev
mailing list