RFR: 8367976: Validate and clamp jdk.httpclient.bufsize [v4]
Volkan Yazici
vyazici at openjdk.org
Tue Oct 21 17:51:48 UTC 2025
On Tue, 21 Oct 2025 09:42:56 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into bufSizeClamp
>> - Switch to POST and repeated-request in `BufferSize1Test`
>> - Apply property doc suggestion
>>
>> Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>
>> - Update `module-info.java` docs
>> - Clamp `Utils::BUFSIZE`
>
> test/jdk/java/net/httpclient/BufferSize1Test.java line 143:
>
>> 141: }
>> 142:
>> 143: private static final class BodyEchoingHandler implements HttpServerAdapters.HttpTestHandler {
>
> You could simply use / extend the HttpServerAdapters.HttpTestEchoHandler;
> Also consider implementing HttpServerAdapters in the test class to get rid of the leading HttpServerAdapters qualifier.
`HttpTestEchoHandler` is a nice tip! In 92f07382f12, employed it and along with styling changes to remove all `HttpServerAdapters` qualifiers.
I'll go with importing whatever I need from `HttpServerAdapters`. I am uncomfortable with extending from `HttpServerAdapters` since its API surface is vast and certain method calls (e.g., `createClientBuilderFor()`) still must be qualified.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27874#discussion_r2449199282
More information about the net-dev
mailing list