RFR: 8355572: Support HTTP Range requests in Simple Web Server [v2]
Daniel Fuchs
dfuchs at openjdk.org
Tue Oct 28 18:38:34 UTC 2025
On Tue, 28 Oct 2025 17:49:29 GMT, Florent Guillaume <duke at openjdk.org> wrote:
>> Peyang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove extra spaces around Path parameter
>>
>> Co-authored-by: Francesco Andreuzzi <andreuzzi.francesco at gmail.com>
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java line 279:
>
>> 277: respHdrs.set("Last-Modified", getLastModified(path));
>> 278: respHdrs.set("Accept-Ranges", "bytes");
>> 279: respHdrs.set("ETag", createETag(path));
>
> ETag is an entirely separate feature from Range and should be in its own separate followup Jira ticket and PR.
In addition should the Etag be considered weak as there is no way to guarantee that the file won't be modified between the time the attributes are read and the time the file content is read?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28021#discussion_r2470657515
More information about the net-dev
mailing list