RFR: 8355572: Support HTTP Range requests in Simple Web Server [v3]
Daniel Fuchs
dfuchs at openjdk.org
Thu Oct 30 12:01:38 UTC 2025
On Wed, 29 Oct 2025 12:21:40 GMT, Peyang <duke at openjdk.org> wrote:
>> Hi all,
>>
>> [JEP 408](https://openjdk.org/jeps/408) introduced the Simple Web Server in Java 18, providing a minimal webserver for serving static files over HTTP.
>>
>> [RFC 9110](https://www.rfc-editor.org/rfc/rfc9110.html#name-range-requests) defines "Range Requests" as an optional feature that allows clients to request a subset of a resource's content. Supporting Range requests in the context of JDK's Simple Web Server means enabling the server to serve only the requested portion of a static file.
>>
>> This change contains:
>>
>> 1. Enhances `sun.net.httpserver.simpleserver.FileServerHandler` in the `jdk.httpserver` module to support `Range` and `If-Range` headers.
>> 2. Calculates an `ETag` for each resource based on its last-modified date and file size and sends it to the client on demand for use with the `If-Range` header.
>> 3. Returns the `Accept-Ranges` header for all file retrievals, and `Content-Range` when a client requests a specific range.
>> 4. Adds a new constant `HTTP_RANGE_NOT_SATISFIABLE` to the `Codes` class to indicate invalid ranges.
>> 5. Returns `206 Partial Content` for valid ranges and `416 Range Not Satisfiable` for invalid ranges.
>> 6. Includes corresponding tests to verify correct behavior.
>>
>> This enhancement was motivated by recent discussions on the net-dev mailing list, which requested support for Range requests along with example use cases: https://mail.openjdk.org/pipermail/net-dev/2025-April/026364.html
>> It was also discussed briefly on the net-dev mailing list: https://mail.openjdk.org/pipermail/net-dev/2025-October/028586.html
>
> Peyang has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove ETag handling from response headers and related tests
I haven't finished reviewing but here are some early feedback.
Also support for Range header will need to be documented in `SimpleFileServer.java`.
See https://docs.oracle.com/en/java/javase/25/docs/api/jdk.httpserver/com/sun/net/httpserver/SimpleFileServer.html#file-handler-heading
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java line 369:
> 367: RangeEntry range = ranges.get(0);
> 368: respHdrs.set("Content-Range",
> 369: "bytes %d-%d/%d".formatted(range.start, range.end, fileSize));
You should use %s rather than %d here because %d is localized.
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java line 382:
> 380: os.write(("--" + boundary + "\r\n").getBytes(UTF_8));
> 381: os.write(("Content-Type: " + fileContentType + "\r\n").getBytes(UTF_8));
> 382: os.write("Content-Range: bytes %d-%d/%d\r\n\r\n"
same here - use %s
-------------
Changes requested by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28021#pullrequestreview-3399231155
PR Review Comment: https://git.openjdk.org/jdk/pull/28021#discussion_r2477820971
PR Review Comment: https://git.openjdk.org/jdk/pull/28021#discussion_r2477824494
More information about the net-dev
mailing list