RFR: 8355572: Support HTTP Range requests in Simple Web Server [v3]
Daniel Fuchs
dfuchs at openjdk.org
Thu Oct 30 13:39:24 UTC 2025
On Thu, 30 Oct 2025 12:39:09 GMT, Peyang <duke at openjdk.org> wrote:
>> Not a reviewer, but I'd go further: this kind of method should be directly unit tested (not indirectly through all the http layers), and full coverage ensured.
>
> Thanks for your reviews.
> Regarding adding comments to the method, I will make the corresponding changes.
> As for the unit tests, it is indeed more reasonable to test this method directly rather than through the HTTP layer.
> With that in mind, would it be okay to make this method package-private so that it can be called from the test code and properly unit tested?
Yes that would be OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28021#discussion_r2478141352
More information about the net-dev
mailing list