RFR: 8368625: com/sun/net/httpserver/ServerStopTerminationTest.java fails intermittently [v3]

Mikhail Yankelevich myankelevich at openjdk.org
Fri Oct 31 12:54:43 UTC 2025


On Wed, 29 Oct 2025 18:12:22 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments
>
> test/jdk/com/sun/net/httpserver/ServerStopTerminationTest.java line 171:
> 
>> 169: 
>> 170:         // Complete the exchange 10 second into the future.
>> 171:         // Runs in parallel, so won't block the server stop
> 
> when we reach here the server has already been stopped. 
> So:
> 
> 1. the comment is inaccurate.
> 2. we don't need the virtual thread or the exchangeDuration here. Just call countDown on the latch directly.
> 3. the first check `elapsed >= exchangeDuration.toNanos()` is not needed - since `exchangeDuration` is not needed.

Changed in the next commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27670#discussion_r2481311305


More information about the net-dev mailing list