RFR: 8371009: HttpClient javadoc synchronous example missing HttpRequest variable declaration [v2]
Daniel Fuchs
dfuchs at openjdk.org
Fri Oct 31 15:29:08 UTC 2025
On Fri, 31 Oct 2025 12:58:39 GMT, EunHyunsu <duke at openjdk.org> wrote:
>> Fixes JDK-8371009.
>>
>> The synchronous HttpClient example references `request` without defining it.
>> This patch adds a minimal HttpRequest initialization immediately before the
>> synchronous example (mirroring the asynchronous snippet) so the example
>> compiles and runs as-is.
>
> EunHyunsu has updated the pull request incrementally with one additional commit since the last revision:
>
> Apply review suggestion: create client before request in HttpClient example
@Michael-Mc-Mahon I believe this change doesn't require a CSR since it's just fixing an example.
@ehs208 did you generate `make docs-jdk-api` and verify that the generated API documentation correctly displays the new changes?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28084#issuecomment-3473590204
More information about the net-dev
mailing list