RFR: 8365983: Tests should throw SkippedException when SCTP not supported [v2]
Jaikiran Pai
jpai at openjdk.org
Tue Sep 2 06:06:43 UTC 2025
On Sat, 23 Aug 2025 02:17:18 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Currently, take test/jdk/com/sun/nio/sctp/SctpMultiChannel/Branch.java as example. When Util.isSCTPSupported() return false, then test print a warning and the exit.
>>
>> I think it's better to throw jtreg.SkippedException rather than only print a warning and then report test passed.
>>
>> Change has been verified locally, test-fix only, almost no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> Replace "throw new jtreg.SkippedException" ad "throw new SkippedException"
test/jdk/com/sun/nio/sctp/SctpMultiChannel/SocketOptionTests.java line 42:
> 40: import com.sun.nio.sctp.AbstractNotificationHandler;
> 41: import com.sun.nio.sctp.Association;
> 42: import com.sun.nio.sctp.SctpStandardSocketOptions.InitMaxStreams;
Was this intentional? Few lines below, there's already a static wildcard import for this:
import static com.sun.nio.sctp.SctpStandardSocketOptions.*;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26903#discussion_r2314996165
More information about the net-dev
mailing list