RFR: 8367067: Improve exception handling in HttpRequest.BodyPublishers [v3]

Jaikiran Pai jpai at openjdk.org
Fri Sep 19 06:38:35 UTC 2025


On Thu, 18 Sep 2025 12:46:43 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Improves exception handling of built-in `HttpClient.BodyPublisher`s to ensure exceptions get propagated in a way compliant with the reactive specification.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix `FileChannelPublisherTest` failures

test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfByteArraysTest.java line 263:

> 261:      * Initiates tests that depend on a custom-configured JVM.
> 262:      */
> 263:     public static void main(String[] args) throws Exception {

Hello Volkan, I am not completely certain whether having a test class which has both a `@run main` and a `@run junit` is guaranteed to always work. What I mean is, I don't know if jtreg will setup the (runtime) classpath to always include junit libraries which will be required by this class (since it references those junit classes) when running the `@run main` action. It might be better to separate out the junit testing and the main() testing into 2 separate test classes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26876#discussion_r2361934948


More information about the net-dev mailing list