RFR: 8367068: Remove redundant HttpRequest.BodyPublisher tests

Volkan Yazici vyazici at openjdk.org
Mon Sep 22 19:11:47 UTC 2025


On Mon, 22 Sep 2025 13:21:26 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> test/jdk/java/net/httpclient/FilePublisherTest.java line 160:
>> 
>>> 158: 
>>> 159:     @Test
>>> 160:     public void testFileNotFound() throws Exception {
>> 
>> Duplicates [OfFileTest::testNonExistentPath].
>> 
>> [OfFileTest::testNonExistentPath]: https://github.com/openjdk/jdk/blob/e8db14f584fa92db170e056bc68074ccabae82c9/test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfFileTest.java#L97
>
> The original test was also testing with a Path coming from a non-default filesystem (ZipFs) - does the new test still have that?

Very sharp of you @dfuch! Yes, it does. See the `@MethodSource("parentDirs")` annotation above the test method, where `parentDirs` is a list composed of

1. a default file system directory, and
2. a ZIP file system directory.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27421#discussion_r2369936453


More information about the net-dev mailing list