RFR: 8318662: Refactor some jdk/java/net/httpclient/http2 tests to JUnit
Volkan Yazici
vyazici at openjdk.org
Mon Sep 22 19:16:59 UTC 2025
On Mon, 22 Sep 2025 14:46:25 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
> I believe you should revert these changes
@dfuch, IMHO, the changes are (partially) necessary since the associated _instance_ variables are switched to _class_ variables, and `this.`-prefixing and variable shadowing do not work anymore. That said, I agree with your suggestion that changes should be minimal and functionally equivalent to the old ones.
> the original code was calling start() on the wrapper, and IMO it's better to continue doing that.
Agreed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27388#discussion_r2369962913
More information about the net-dev
mailing list