RFR: 8318662: Refactor some jdk/java/net/httpclient/http2 tests to JUnit [v3]

Volkan Yazici vyazici at openjdk.org
Wed Sep 24 11:47:52 UTC 2025


On Wed, 24 Sep 2025 11:34:22 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:

>> Refactoring following httpclient/http2 testng test to JUnit :
>> test/jdk/java/net/httpclient/http2/BadHeadersTest.java
>> test/jdk/java/net/httpclient/http2/BadPushPromiseTest.java
>> test/jdk/java/net/httpclient/http2/BasicTest.java
>> test/jdk/java/net/httpclient/http2/ConnectionFlowControlTest.java
>> test/jdk/java/net/httpclient/http2/ContinuationFrameTest.java
>
> Mahendra Chhipa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Updated test data indentation.
>  - Merge branch 'master' into JDK-8318662
>  - Implemented the review comments.
>  - JDK-8318662: Refactor some jdk/java/net/httpclient/http2 tests to JUnit

Changes requested by vyazici (Committer).

test/jdk/java/net/httpclient/http2/ConnectionFlowControlTest.java line 33:

> 31:  *              -Djdk.httpclient.connectionWindowSize=65535
> 32:  *              -Djdk.httpclient.windowsize=16384
> 33:  *              ConnectionFlowControlTest

Could you also revert these, please?

test/jdk/java/net/httpclient/http2/ContinuationFrameTest.java line 150:

> 148:                 { https2URI,       false, byteAtATime},
> 149:                 { http2URI,        true,  byteAtATime},
> 150:                 { https2URI,       true,  byteAtATime},

Could you also revert these, please?

-------------

PR Review: https://git.openjdk.org/jdk/pull/27388#pullrequestreview-3262500457
PR Review Comment: https://git.openjdk.org/jdk/pull/27388#discussion_r2375512679
PR Review Comment: https://git.openjdk.org/jdk/pull/27388#discussion_r2375512047


More information about the net-dev mailing list